summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Walzer <kw@codebykevin.com>2015-02-12 15:34:54 (GMT)
committerKevin Walzer <kw@codebykevin.com>2015-02-12 15:34:54 (GMT)
commit7187b8fcc22f915f42da6873079c79969b031b03 (patch)
tree678d69bb87084a4fd26c694beaca56bba92c1b31
parentf0588ea6f1632841dfe7ed350ea5c0e78331882d (diff)
downloadtk-7187b8fcc22f915f42da6873079c79969b031b03.zip
tk-7187b8fcc22f915f42da6873079c79969b031b03.tar.gz
tk-7187b8fcc22f915f42da6873079c79969b031b03.tar.bz2
Cleaner implementation of metrics for radiobuttons and checkbuttons under Cocoa; still a bit of extra padding required, but only when absolutely necessary
-rw-r--r--macosx/tkMacOSXButton.c47
1 files changed, 25 insertions, 22 deletions
diff --git a/macosx/tkMacOSXButton.c b/macosx/tkMacOSXButton.c
index 763f544..9c2196f 100644
--- a/macosx/tkMacOSXButton.c
+++ b/macosx/tkMacOSXButton.c
@@ -296,24 +296,6 @@ TkpComputeButtonGeometry(
haveImage = 1;
}
- /*Tk Aqua can't handle metrics for radiobuttons and checkbuttons with images unless they are set first. These are derived from experimentation.*/
- if (haveImage && !haveText) {
- switch (butPtr->type) {
- case TYPE_RADIO_BUTTON:
- width = butPtr->width;
- width +=50;
- break;
- case TYPE_CHECK_BUTTON:
- width = butPtr->width;
- width +=50;
- break;
- case TYPE_BUTTON:
- width = butPtr->width;
- width += 0;
- break;
- }
- }
-
if (haveImage == 0 || butPtr->compound != COMPOUND_NONE) {
Tk_FreeTextLayout(butPtr->textLayout);
butPtr->textLayout = Tk_ComputeTextLayout(butPtr->tkfont,
@@ -396,16 +378,37 @@ TkpComputeButtonGeometry(
width += 2 * butPtr->padX;
height += 2 * butPtr->padY;
-
- /* Need special handling for radiobuttons and checkbuttons: the text is drawn right on top of the button unless we expand the width. This is not perfect; some radiobuttons may render on top anyway. Need to find a better solution to calculate average text width.*/
+ /* Need special handling for radiobuttons and checkbuttons:
+ the text and images is drawn right on top of the button unless
+ we expand the width. This is not perfect; some radiobuttons may render
+ on top anyway.
+ */
switch (butPtr->type) {
case TYPE_RADIO_BUTTON:
- width += 50;
+ /*Pad radiobutton by 50 to ensure image does not draw right over
+ radiobutton on left.*/
+ if (butPtr->image != None) {
+ width += 50;
+ } else if (butPtr->bitmap != None) {
+ width +=50;
+ } else {
+ /*If just text, just add width of string.*/
+ width += txtWidth;
+ }
break;
case TYPE_CHECK_BUTTON:
- width += 50;
+ /*No padding required here.*/
+ if (butPtr->image != None) {
+ width += 0;
+ } else if (butPtr->bitmap != None) {
+ width +=0;
+ } else {
+ /*If just text, just add width of string.*/
+ width += txtWidth;
+ }
break;
}
+
/*
* Now figure out the size of the border decorations for the button.