Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 7 insertions, 7 deletions

diff --git a/library/demos/bind.tcl b/library/demos/bind.tcl
index d9bc22f..e1a064f 100644
--- a/library/demos/bind.tcl
+++ b/library/demos/bind.tcl
@@ -10,7 +10,7 @@ if {![info exists widgetDemo]} {
 package require Tk
 
 set w .bind
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "Text Demonstration - Tag Bindings"
 wm iconname $w "bind"
@@ -43,22 +43,22 @@ The same tag mechanism that controls display styles in text widgets can also be
 
 }
 $w.text insert end \
-{1. Samples of all the different types of items that can be created in canvas widgets.} d1
+"1. Samples of all the different types of items that can be created in canvas widgets." d1
 $w.text insert end \n\n
 $w.text insert end \
-{2. A simple two-dimensional plot that allows you to adjust the positions of the data points.} d2
+"2. A simple two-dimensional plot that allows you to adjust the positions of the data points." d2
 $w.text insert end \n\n
 $w.text insert end \
-{3. Anchoring and justification modes for text items.} d3
+"3. Anchoring and justification modes for text items." d3
 $w.text insert end \n\n
 $w.text insert end \
-{4. An editor for arrow-head shapes for line items.} d4
+"4. An editor for arrow-head shapes for line items." d4
 $w.text insert end \n\n
 $w.text insert end \
-{5. A ruler with facilities for editing tab stops.} d5
+"5. A ruler with facilities for editing tab stops." d5
 $w.text insert end \n\n
 $w.text insert end \
-{6. A grid that demonstrates how canvases can be scrolled.} d6
+"6. A grid that demonstrates how canvases can be scrolled." d6
 
 # Create bindings for tags.