Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 6 insertions, 6 deletions

diff --git a/library/demos/browse b/library/demos/browse
index d107f28..2e20f9a 100644
--- a/library/demos/browse
+++ b/library/demos/browse
@@ -27,16 +27,16 @@ wm minsize . 1 1
 set browseScript [file join [pwd] $argv0]
 proc browse {dir file} {
     global env browseScript
-    if {[string compare $dir "."] != 0} {set file $dir/$file}
-    switch [file type $file] {
+    if {$dir ne "."} {set file [file join $dir $file]}
+    switch -- [file type $file] {
 	directory {
-	    exec [info nameofexecutable] $browseScript $file &
+	    exec -- [info nameofexecutable] $browseScript $file &
 	}
 	file {
 	    if {[info exists env(EDITOR)]} {
-		eval exec $env(EDITOR) $file &
+		eval exec -- $env(EDITOR) $file &
 	    } else {
-		exec xedit $file &
+		exec -- xedit $file &
 	    }
 	}
 	default {
@@ -47,7 +47,7 @@ proc browse {dir file} {
 
 # Fill the listbox with a list of all the files in the directory.
 
-if {$argc>0} {set dir [lindex $argv 0]} else {set dir "."}
+if {$argc > 0} {set dir [lindex $argv 0]} else {set dir "."}
 foreach i [lsort [glob * .* *.*]] {
     if {[file type $i] eq "directory"} {
 	# Safe to do since it is still a directory.