Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 3 insertions, 3 deletions

diff --git a/library/demos/filebox.tcl b/library/demos/filebox.tcl
index e06ebba..61cee5e 100644
--- a/library/demos/filebox.tcl
+++ b/library/demos/filebox.tcl
@@ -9,7 +9,7 @@ if {![info exists widgetDemo]} {
 package require Tk
 
 set w .filebox
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "File Selection Dialogs"
 wm iconname $w "filebox"
@@ -61,7 +61,7 @@ proc fileDialog {w ent operation} {
 	{"Image Files"		""		{GIFF JPEG}}
 	{"All files"		*}
     }
-    if {$operation == "open"} {
+    if {$operation eq "open"} {
 	global selected_type
 	if {![info exists selected_type]} {
 	    set selected_type "Tcl Scripts"
@@ -73,7 +73,7 @@ proc fileDialog {w ent operation} {
 	set file [tk_getSaveFile -filetypes $types -parent $w \
 		-initialfile Untitled -defaultextension .txt]
     }
-    if {[string compare $file ""]} {
+    if {$file ne ""} {
 	$ent delete 0 end
 	$ent insert 0 $file
 	$ent xview end