Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 5 insertions, 5 deletions

diff --git a/library/demos/image2.tcl b/library/demos/image2.tcl
index a17da31..b1c3bbb 100644
--- a/library/demos/image2.tcl
+++ b/library/demos/image2.tcl
@@ -16,7 +16,7 @@ package require Tk
 # Arguments:
 # w -			Name of the toplevel window of the demo.
 
-proc loadDir w {
+proc loadDir {w} {
     global dirName
 
     $w.f.list delete 0 end
@@ -33,7 +33,7 @@ proc loadDir w {
 # Arguments:
 # w -			Name of the toplevel window of the demo.
 
-proc selectAndLoadDir w {
+proc selectAndLoadDir {w} {
     global dirName
     set dir [tk_chooseDirectory -initialdir $dirName -parent $w -mustexist 1]
     if {$dir ne ""} {
@@ -57,14 +57,14 @@ proc loadImage {w x y} {
     set file [file join $dirName [$w.f.list get @$x,$y]]
     if {[catch {
 	image2a configure -file $file
-    }]} then {
+    }]} {
 	# Mark the file as not loadable
-	$w.f.list itemconfigure @$x,$y -bg \#c00000 -selectbackground \#ff0000
+	$w.f.list itemconfigure @$x,$y -background "#c00000" -selectbackground "#ff0000"
     }
 }
 
 set w .image2
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "Image Demonstration #2"
 wm iconname $w "Image2"