Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 2 insertions, 3 deletions

diff --git a/library/demos/radio.tcl b/library/demos/radio.tcl
index 5c73703..26217ec 100644
--- a/library/demos/radio.tcl
+++ b/library/demos/radio.tcl
@@ -10,7 +10,7 @@ if {![info exists widgetDemo]} {
 package require Tk
 
 set w .radio
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "Radiobutton Demonstration"
 wm iconname $w "radio"
@@ -25,7 +25,7 @@ grid $btns -row 3 -column 0 -columnspan 3 -sticky ew
 labelframe $w.left -pady 2 -text "Point Size" -padx 2
 labelframe $w.mid -pady 2 -text "Color" -padx 2
 labelframe $w.right -pady 2 -text "Alignment" -padx 2
-button $w.tristate -text Tristate -command "set size multi; set color multi" \
+button $w.tristate -text Tristate -command "lassign [list multi multi] size color" \
     -pady 2 -padx 2
 if {[tk windowingsystem] eq "aqua"} {
     $w.tristate configure -padx 10
@@ -50,7 +50,6 @@ foreach c {Red Green Blue Yellow Orange Purple} {
     pack $w.mid.$lower -side top -pady 2 -fill x
 }
 
-
 label $w.right.l -text "Label" -bitmap questhead -compound left
 $w.right.l configure -width [winfo reqwidth $w.right.l] -compound top
 $w.right.l configure -height [winfo reqheight $w.right.l]