Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 4 insertions, 4 deletions

diff --git a/library/demos/rmt b/library/demos/rmt
index 51886de..81c9f8c 100644
--- a/library/demos/rmt
+++ b/library/demos/rmt
@@ -116,7 +116,7 @@ proc tk::TextInsert {w s} {
     catch {
 	if {
 	    [$w compare sel.first <= insert] && [$w compare sel.last >= insert]
-	} then {
+	} {
 	    $w tag remove sel sel.first promptEnd
 	    $w delete sel.first sel.last
 	}
@@ -125,8 +125,8 @@ proc tk::TextInsert {w s} {
     $w see insert
 }
 
-.t configure -font {Courier 12}
-.t tag configure bold -font {Courier 12 bold}
+.t configure -font "Courier 12"
+.t tag configure bold -font "Courier 12 bold"
 
 # The procedure below is used to print out a prompt at the
 # insertion point (which should be at the beginning of a line
@@ -177,7 +177,7 @@ proc invoke {} {
 # the text item (in which case a new prompt is about to be output
 # so there's no need to change the old one).
 
-proc newApp appName {
+proc newApp {appName} {
     global app executing
     set app $appName
     if {!$executing} {