Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 5 insertions, 4 deletions

diff --git a/library/demos/text.tcl b/library/demos/text.tcl
index 785e9e6..2301ad5 100644
--- a/library/demos/text.tcl
+++ b/library/demos/text.tcl
@@ -10,7 +10,7 @@ if {![info exists widgetDemo]} {
 package require Tk
 
 set w .text
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "Text Demonstration - Basic Facilities"
 wm iconname $w "text"
@@ -29,11 +29,11 @@ pack $w.text -expand yes -fill both
 
 # TIP 324 Demo: [tk fontchooser]
 proc fontchooserToggle {} {
-    tk fontchooser [expr {[tk fontchooser configure -visible] ?
+    tk fontchooser [expr {[tk fontchooser configure -visible] ? 
             "hide" : "show"}]
 }
 proc fontchooserVisibility {w} {
-    $w configure -text [expr {[tk fontchooser configure -visible] ?
+    $w configure -text [expr {[tk fontchooser configure -visible] ? 
             "Hide Font Dialog" : "Show Font Dialog"}]
 }
 proc fontchooserFocus {w} {
@@ -92,13 +92,14 @@ cursor.  Control-t transposes the two characters on either side of the
 insertion cursor.  Control-z undoes the last editing action performed,
 and }
 
-switch [tk windowingsystem] {
+switch -- [tk windowingsystem] {
     "aqua" - "x11" {
 	$w.text insert end "Control-Shift-z"
     }
     "win32" {
 	$w.text insert end "Control-y"
     }
+    default {}
 }
 
 $w.text insert end { redoes undone edits.