Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 4 insertions, 4 deletions

diff --git a/library/demos/timer b/library/demos/timer
index e10b840..6f0be41 100644
--- a/library/demos/timer
+++ b/library/demos/timer
@@ -12,7 +12,7 @@ label .counter -text 0.00 -relief raised -width 10 -padx 2m -pady 1m
 button .start -text Start -command {
     if {$stopped} {
 	set stopped 0
-	set startMoment [clock clicks -milliseconds]
+	set startMoment [clock milliseconds]
 	tick
 	.stop configure -state normal
 	.start configure -state disabled
@@ -27,7 +27,7 @@ pack .counter -side bottom -fill both
 pack .start -side left -fill both -expand yes
 pack .stop -side right -fill both -expand yes
 
-set startMoment {}
+set startMoment ""
 
 set stopped 1
 
@@ -35,8 +35,8 @@ proc tick {} {
     global startMoment stopped
     if {$stopped} {return}
     after 50 tick
-    set elapsedMS [expr {[clock clicks -milliseconds] - $startMoment}]
-    .counter config -text [format "%.2f" [expr {double($elapsedMS)/1000}]]
+    set elapsedMS [expr {[clock milliseconds] - $startMoment}]
+    .counter config -text [format "%.2f" [expr {$elapsedMS * 1e-3}]]
 }
 
 bind . <Control-c> {destroy .}