Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 6 insertions, 6 deletions

diff --git a/library/demos/tree.tcl b/library/demos/tree.tcl
index 71c32c1..288e90c 100644
--- a/library/demos/tree.tcl
+++ b/library/demos/tree.tcl
@@ -10,7 +10,7 @@ if {![info exists widgetDemo]} {
 package require Tk
 
 set w .tree
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "Directory Browser"
 wm iconname $w "tree"
@@ -51,12 +51,12 @@ proc populateTree {tree node} {
 	} elseif {$type eq "file"} {
 	    set size [file size $f]
 	    ## Format the file size nicely
-	    if {$size >= 1024*1024*1024} {
-		set size [format %.1f\ GB [expr {$size/1024/1024/1024.}]]
-	    } elseif {$size >= 1024*1024} {
-		set size [format %.1f\ MB [expr {$size/1024/1024.}]]
+	    if {$size >= (1024 ** 3)} {
+		set size [format %.1f\ GB [expr {$size / (1024.0 ** 3)}]]
+	    } elseif {$size >= (1024 ** 2)} {
+		set size [format %.1f\ MB [expr {$size / (1024.0 ** 2)}]]
 	    } elseif {$size >= 1024} {
-		set size [format %.1f\ kB [expr {$size/1024.}]]
+		set size [format %.1f\ kB [expr {$size / 1024.0}]]
 	    } else {
 		append size " bytes"
 	    }