Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 2 insertions, 2 deletions

diff --git a/library/demos/ttkbut.tcl b/library/demos/ttkbut.tcl
index 904cd31..79bad3d 100644
--- a/library/demos/ttkbut.tcl
+++ b/library/demos/ttkbut.tcl
@@ -11,7 +11,7 @@ if {![info exists widgetDemo]} {
 package require Tk
 
 set w .ttkbut
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "Simple Ttk Widgets"
 wm iconname $w "ttkbut"
@@ -26,7 +26,7 @@ pack [addSeeDismiss $w.seeDismiss $w {enabled cheese tomato basil oregano happyn
 
 ## Add buttons for setting the theme
 ttk::labelframe $w.buttons -text "Buttons"
-foreach theme [ttk::themes] {
+foreach theme [ttk::style theme names] {
     ttk::button $w.buttons.$theme -text $theme \
 	    -command [list ttk::setTheme $theme]
     pack $w.buttons.$theme -pady 2