Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 3 insertions, 3 deletions

diff --git a/library/demos/unicodeout.tcl b/library/demos/unicodeout.tcl
index faa9f90..a34ddc6 100644
--- a/library/demos/unicodeout.tcl
+++ b/library/demos/unicodeout.tcl
@@ -10,7 +10,7 @@ if {![info exists widgetDemo]} {
 package require Tk
 
 set w .unicodeout
-catch {destroy $w}
+destroy $w
 toplevel $w
 wm title $w "Unicode Label Demonstration"
 wm iconname $w "unicodeout"
@@ -47,7 +47,7 @@ proc addSample {w language args} {
 ## A helper procedure that determines what form to use to express languages
 ## that have complex rendering rules...
 proc usePresentationFormsFor {language} {
-    switch [tk windowingsystem] {
+    switch -- [tk windowingsystem] {
 	aqua {
 	    # OSX wants natural character order; the renderer knows how to
 	    # compose things for display for all languages.
@@ -90,7 +90,7 @@ proc usePresentationFormsFor {language} {
 ## engine might take a while, so make sure we're displaying something in the
 ## meantime...
 pack [label $w.wait -text "Please wait while loading fonts..." \
-	-font {Helvetica 12 italic}]
+	-font "Helvetica 12 italic"]
 set oldCursor [$w cget -cursor]
 $w conf -cursor watch
 update