Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 4 insertions, 4 deletions

diff --git a/library/safetk.tcl b/library/safetk.tcl
index 9f8e25d..ab6fbbd 100644
--- a/library/safetk.tcl
+++ b/library/safetk.tcl
@@ -63,8 +63,8 @@ proc ::safe::loadTk {} {}
 
 ::tcl::OptProc ::safe::loadTk {
     {slave -interp "name of the slave interpreter"}
-    {-use  -windowId {} "window Id to use (new toplevel otherwise)"}
-    {-display -displayName {} "display name to use (current one otherwise)"}
+    {-use  -windowId "" "window Id to use (new toplevel otherwise)"}
+    {-display -displayName "" "display name to use (current one otherwise)"}
 } {
     set displayGiven [::tcl::OptProcArgGiven "-display"]
     if {!$displayGiven} {
@@ -89,7 +89,7 @@ proc ::safe::loadTk {} {}
 
 	# set our delete hook (slave arg is added by interpDelete)
 	# to clean up both window related code and tkInit(slave)
-	set state(cleanupHook) [list tkDelete {} $w]
+	set state(cleanupHook) [list tkDelete "" $w]
     } else {
 	# set our delete hook (slave arg is added by interpDelete)
 	# to clean up tkInit(slave)
@@ -125,7 +125,7 @@ proc ::safe::loadTk {} {}
     # Prepares the slave for tk with those parameters
     tkInterpInit $slave [list "-use" $use "-display" $display]
 
-    load {} Tk $slave
+    load "" Tk $slave
 
     return $slave
 }