Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 5 insertions, 4 deletions

diff --git a/library/tearoff.tcl b/library/tearoff.tcl
index 6da2a0f..b756a1d 100644
--- a/library/tearoff.tcl
+++ b/library/tearoff.tcl
@@ -44,14 +44,14 @@ proc ::tk::TearOffMenu {w {x 0} {y 0}} {
     }
 
     set parent [winfo parent $w]
-    while {[winfo toplevel $parent] ne $parent \
-	    || [winfo class $parent] eq "Menu"} {
+    while {([winfo toplevel $parent] ne $parent) || 
+	   ([winfo class $parent] eq "Menu")} {
 	set parent [winfo parent $parent]
     }
     if {$parent eq "."} {
 	set parent ""
     }
-    for {set i 1} 1 {incr i} {
+    for {set i 1} {1} {incr i} {
 	set menu $parent.tearoff$i
 	if {![winfo exists $menu]} {
 	    break
@@ -75,6 +75,7 @@ proc ::tk::TearOffMenu {w {x 0} {y 0}} {
 	    Menu {
 	    	wm title $menu [$parent entrycget active -label]
 	    }
+	    default {}
 	}
     }
 
@@ -90,7 +91,7 @@ proc ::tk::TearOffMenu {w {x 0} {y 0}} {
 
     $menu post $x $y
 
-    if {[winfo exists $menu] == 0} {
+    if {![winfo exists $menu]} {
 	return ""
     }