summaryrefslogtreecommitdiffstats
path: root/library/ttk/sizegrip.tcl
diff options
context:
space:
mode:
authorandreask <andreask>2013-01-22 19:30:43 (GMT)
committerandreask <andreask>2013-01-22 19:30:43 (GMT)
commit48c9fcb7281cc6aa076113db874c7ae0e105795d (patch)
tree7187940ff056462bfa41705a2ce04d0ed07d424e /library/ttk/sizegrip.tcl
parent41f5d19540b0b3f053da352e1569c9a4ed019dd5 (diff)
downloadtk-contrib_patrick_fradin_code_cleanup.zip
tk-contrib_patrick_fradin_code_cleanup.tar.gz
tk-contrib_patrick_fradin_code_cleanup.tar.bz2
Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup
Quoting his mail: <pre> ========================================================== Hi Jeff, I spent some of my time to contribute to the TclTk community ! I'm in late for Christmas gift but like we said in French : "Mieux vaut tard que jamais". ;-) I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and Tk library directories (library, tools and tests) to correct a lot of warnings and few errors. (encapsulate some expr, use 'chan xxx' instead of fconfigure, fileevent...) I've made some improvements too : Examples : - Use 'lassign' instead of many 'lindex' of 'foreach/break' loop. - Use 'in' or 'ni' operators instead of 'lsearch -exact' or to factorise some eq/ne && / || tests. - Use 'eq' or 'ne' to tests strings instead of '==' or '!='. - Use 'unset -nocomplain' to avoid 'catch {unset...}'. - Remove some useless catch around 'destroy' calls. - Use expand {*} instead of 'eval'. Don't touch a lot of code because I don't know all structs and lists. I think it could be a greater improvement to reduce 'eval' calls. Due to previous experience, I dot not change any indentation ! ;-) ========================================================== </pre>
Diffstat (limited to 'library/ttk/sizegrip.tcl')
-rw-r--r--library/ttk/sizegrip.tcl8
1 files changed, 5 insertions, 3 deletions
diff --git a/library/ttk/sizegrip.tcl b/library/ttk/sizegrip.tcl
index 153e310..7b86640 100644
--- a/library/ttk/sizegrip.tcl
+++ b/library/ttk/sizegrip.tcl
@@ -14,6 +14,7 @@ switch -- [tk windowingsystem] {
aqua {
# Aqua sizegrips use default Arrow cursor.
}
+ default {}
}
namespace eval ttk::sizegrip {
@@ -83,14 +84,15 @@ proc ttk::sizegrip::Drag {W X Y} {
set w $State(width)
set h $State(height)
if {$State(resizeX)} {
- set w [expr {$w + ($X - $State(pressX))/$State(widthInc)}]
+ set w [expr {$w + (($X - $State(pressX)) / $State(widthInc))}]
}
if {$State(resizeY)} {
- set h [expr {$h + ($Y - $State(pressY))/$State(heightInc)}]
+ set h [expr {$h + (($Y - $State(pressY)) / $State(heightInc))}]
}
if {$w <= 0} { set w 1 }
if {$h <= 0} { set h 1 }
- set x $State(x) ; set y $State(y)
+ set x $State(x)
+ set y $State(y)
wm geometry $State(toplevel) ${w}x${h}+${x}+${y}
}