Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 6 insertions, 6 deletions

diff --git a/tests/bevel.tcl b/tests/bevel.tcl
index 950b714..70c45fc 100644
--- a/tests/bevel.tcl
+++ b/tests/bevel.tcl
@@ -2,15 +2,15 @@
 # widgets.  It is part of the Tk visual test suite, which is invoked
 # via the "visual" script.
 
-catch {destroy .t}
+destroy .t
 toplevel .t
 wm title .t "Visual Tests for Borders in Text Widgets"
 wm iconname .t "Text Borders"
 wm geom .t +0+0
 
 text .t.t -width 60 -height 30 -setgrid true -xscrollcommand {.t.h set} \
-	-font {Courier 12} \
-	-yscrollcommand {.t.v set} -wrap none -relief raised -bd 2
+	-font "Courier 12" \
+	-yscrollcommand {.t.v set} -wrap none -relief raised -borderwidth 2
 scrollbar .t.v -orient vertical -command ".t.t yview"
 scrollbar .t.h -orient horizontal -command ".t.t xview"
 button .t.quit -text Quit -command {destroy .t}
@@ -21,10 +21,10 @@ pack .t.t -expand yes -fill both
 wm minsize .t 1 1
 
 if {[winfo depth .t] > 1} {
-    .t.t tag configure r1 -relief raised -borderwidth 2 -background #b2dfee
-    .t.t tag configure r2 -relief raised -borderwidth 2 -background #b2dfee \
+    .t.t tag configure r1 -relief raised -borderwidth 2 -background "#b2dfee"
+    .t.t tag configure r2 -relief raised -borderwidth 2 -background "#b2dfee" \
 	    -offset 2
-    .t.t tag configure s1 -relief sunken -borderwidth 2 -background #b2dfee
+    .t.t tag configure s1 -relief sunken -borderwidth 2 -background "#b2dfee"
 } else {
     .t.t tag configure r1 -relief raised -borderwidth 2 -background white
     .t.t tag configure r2 -relief raised -borderwidth 2 -background white \