Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 6 insertions, 6 deletions

diff --git a/tests/canvPsArc.tcl b/tests/canvPsArc.tcl
index ef7ca6c..0120909 100644
--- a/tests/canvPsArc.tcl
+++ b/tests/canvPsArc.tcl
@@ -2,7 +2,7 @@
 # for bitmaps in canvases.  It is part of the Tk visual test suite,
 # which is invoked via the "visual" script.
 
-catch {destroy .t}
+destroy .t
 toplevel .t
 wm title .t "Postscript Tests for Canvases"
 wm iconname .t "Postscript"
@@ -20,22 +20,22 @@ button .t.bot.quit -text Quit -command {destroy .t}
 button .t.bot.print -text Print -command "lpr $c"
 pack .t.bot.print .t.bot.quit -side left -pady 1m -expand 1
 
-canvas $c -width 6i -height 6i -bd 2 -relief sunken
+canvas $c -width 6i -height 6i -borderwidth 2 -relief sunken
 pack $c -expand yes -fill both -padx 2m -pady 2m
 
 $c create arc .5i .5i 2i 2i -style pieslice -start 20 -extent 90 \
-    -fill black -outline {}
+    -fill black -outline ""
 $c create arc 2.5i 0 4.5i 1i -style pieslice -start -45 -extent -135 \
-    -fill {} -outline black -outlinestipple gray50 -width 3m
+    -fill "" -outline black -outlinestipple gray50 -width 3m
 $c create arc 5.0i .5i 6.5i 2i -style pieslice -start 45 -extent 315 \
     -fill black -stipple gray25 -outline black -width 1m
 
 $c create arc -.5i 2.5i 2.0i 3.5i -style chord -start 90 -extent 270 \
-    -fill black -outline {}
+    -fill black -outline ""
 $c create arc 2.5i 2i 4i 6i -style chord -start 20 -extent 140 \
     -fill black -stipple gray50 -outline black -width 2m
 $c create arc 4i 2.5i 8i 4.5i -style chord -start 60 -extent 60 \
-    -fill {} -outline black
+    -fill "" -outline black
 
 $c create arc .5i 4.5i 2i 6i -style arc -start 135 -extent 315 -width 3m \
     -outline black -outlinestipple gray25