Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 3 insertions, 3 deletions

diff --git a/tests/canvPsImg.tcl b/tests/canvPsImg.tcl
index c06aeaa..57b8f55 100644
--- a/tests/canvPsImg.tcl
+++ b/tests/canvPsImg.tcl
@@ -5,14 +5,14 @@
 # Build a test image in a canvas
 proc BuildTestImage {} {
     global BitmapImage PhotoImage visual level
-    catch {destroy .t.f}
+    destroy .t.f
     frame .t.f -visual $visual -colormap new
     pack .t.f -side top -after .t.top
     bind .t.f <Enter> {wm colormapwindows .t {.t.f .t}}
     bind .t.f <Leave> {wm colormapwindows .t {.t .t.f}}
     canvas .t.f.c -width 550 -height 350 -borderwidth 2 -relief raised
     pack .t.f.c
-    .t.f.c create rectangle 25 25 525 325 -fill {} -outline black
+    .t.f.c create rectangle 25 25 525 325 -fill "" -outline black
     .t.f.c create image 50 50 -anchor nw -image $BitmapImage
     .t.f.c create image 250 50 -anchor nw -image $PhotoImage
 }
@@ -30,7 +30,7 @@ proc PrintPostcript { canvas } {
     exec lpr tmp.ps
 }
 
-catch {destroy .t}
+destroy .t
 toplevel .t
 wm title .t "Postscript Tests for Canvases: Images"
 wm iconname .t "Postscript"