Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 8 insertions, 8 deletions

diff --git a/tests/canvWind.test b/tests/canvWind.test
index 436ee2c..3bc8739 100644
--- a/tests/canvWind.test
+++ b/tests/canvWind.test
@@ -15,13 +15,13 @@ test canvWind-1.1 {DisplayWinItem, windows off-screen vertically} -setup {
     destroy .t
 } -body {
     toplevel .t
-    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -bd 2 \
+    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -borderwidth 2 \
 	    -relief sunken -xscrollincrement 1 -yscrollincrement 1 \
 	    -highlightthickness 1
     pack .t.c -fill both -expand 1 -padx 20 -pady 20
     wm geometry .t +0+0
     set f .t.f
-    frame $f -width 80 -height 50 -bg red
+    frame $f -width 80 -height 50 -background red
     .t.c create window 300 400 -window $f -anchor nw
     .t.c xview moveto .3
     .t.c yview moveto .50
@@ -47,13 +47,13 @@ test canvWind-1.2 {DisplayWinItem, windows off-screen vertically} -setup {
     destroy .t
 } -body {
     toplevel .t
-    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -bd 2 \
+    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -borderwidth 2 \
 	    -relief sunken -xscrollincrement 1 -yscrollincrement 1 \
 	    -highlightthickness 1
     pack .t.c -fill both -expand 1 -padx 20 -pady 20
     wm geometry .t +0+0
     set f .t.c.f
-    frame $f -width 80 -height 50 -bg red
+    frame $f -width 80 -height 50 -background red
     .t.c create window 300 400 -window $f -anchor nw
     .t.c xview moveto .3
     .t.c yview moveto .50
@@ -79,13 +79,13 @@ test canvWind-1.3 {DisplayWinItem, windows off-screen horizontally} -setup {
     destroy .t
 } -body {
     toplevel .t
-    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -bd 2 \
+    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -borderwidth 2 \
 	    -relief sunken -xscrollincrement 1 -yscrollincrement 1 \
 	    -highlightthickness 1
     pack .t.c -fill both -expand 1 -padx 20 -pady 20
     wm geometry .t +0+0
     set f .t.f
-    frame $f -width 80 -height 50 -bg red
+    frame $f -width 80 -height 50 -background red
     .t.c create window 300 400 -window $f -anchor nw
     .t.c xview moveto .3
     .t.c yview moveto .50
@@ -111,13 +111,13 @@ test canvWind-1.4 {DisplayWinItem, windows off-screen horizontally} -setup {
     destroy .t
 } -body {
     toplevel .t
-    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -bd 2 \
+    canvas .t.c -scrollregion {0 0 1000 800} -width 250 -height 200 -borderwidth 2 \
 	    -relief sunken -xscrollincrement 1 -yscrollincrement 1 \
 	    -highlightthickness 1
     pack .t.c -fill both -expand 1 -padx 20 -pady 20
     wm geometry .t +0+0
     set f .t.c.f
-    frame $f -width 80 -height 50 -bg red
+    frame $f -width 80 -height 50 -background red
     .t.c create window 300 400 -window $f -anchor nw
     .t.c xview moveto .3
     .t.c yview moveto .50