Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 2 insertions, 4 deletions

diff --git a/tests/cursor.test b/tests/cursor.test
index 1039b52..835d767 100644
--- a/tests/cursor.test
+++ b/tests/cursor.test
@@ -11,11 +11,10 @@ namespace import ::tcltest::*
 eval tcltest::configure $argv
 tcltest::loadTestedCommands
 
-
 # Tests 2.3 and 2.4 need a helper file with a very specific name and
 # controlled format.
 proc setWincur {wincurName} {
-	upvar $wincurName wincur
+	upvar 1 $wincurName wincur
 	set wincur(data_octal) {
 	    000 000 002 000 001 000 040 040 000 000 007 000 007 000 060 001
 	    000 000 026 000 000 000 050 000 000 000 040 000 000 000 100 000
@@ -39,7 +38,7 @@ proc setWincur {wincurName} {
 	    377 377 200 001 377 377 001 200 377 377 003 300 377 377 007 340
 	    377 377 017 360 377 377
 	}
-	set wincur(data_binary) {}
+	set wincur(data_binary) ""
 	foreach wincur(num) $wincur(data_octal) {
 	    append wincur(data_binary) [binary format c [scan $wincur(num) %o]]
 	}
@@ -47,7 +46,6 @@ proc setWincur {wincurName} {
 	set wincur(file) [makeFile $wincur(data_binary) "test file.cur" $wincur(dir)]
 }
 
-
 test cursor-1.1 {Tk_AllocCursorFromObj - converting internal reps} -constraints {
     testcursor
 } -body {