Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 4 insertions, 7 deletions

diff --git a/tests/msgbox.test b/tests/msgbox.test
index 643ae2c..835575c 100644
--- a/tests/msgbox.test
+++ b/tests/msgbox.test
@@ -10,7 +10,6 @@ eval tcltest::configure $argv
 tcltest::loadTestedCommands
 namespace import -force tcltest::test
 
-
 test msgbox-1.1 {tk_messageBox command} -body {
     tk_messageBox -foo
 } -returnCodes error -result {bad option "-foo": must be -default, -detail, -icon, -message, -parent, -title, or -type}
@@ -76,9 +75,8 @@ test msgbox-1.19 {tk_messageBox command} -body {
     tk_messageBox -parent foo.bar
 } -returnCodes error -result {bad window path name "foo.bar"}
 
-
 catch {tk_messageBox -foo bar}
-set isNative [expr {[info commands tk::MessageBox] == ""}]
+set isNative [expr {[info commands tk::MessageBox] eq ""}]
 
 proc ChooseMsg {parent btn} {
     global isNative
@@ -101,15 +99,15 @@ proc PressButton {btn} {
 }
 
 proc SendEventToMsg {parent btn type} {
-    if {$parent != "."} {
+    if {$parent ne "."} {
 	set w $parent.__tk__messagebox
     } else {
 	set w .__tk__messagebox
     }
-    if ![winfo ismapped $w.$btn] {
+    if {![winfo ismapped $w.$btn]} {
 	update
     }
-    if {$type == "mouse"} {
+    if {$type eq "mouse"} {
 	PressButton $w.$btn
     } else {
 	event generate $w <Enter>
@@ -418,7 +416,6 @@ test msgbox-2.43 {tk_messageBox command} -constraints {
         -type yesnocancel -default cancel
 } -result {cancel}
 
-
 # These tests will hang your test suite if they fail.
 test msgbox-3.1 {tk_messageBox handles withdrawn parent} -constraints {
 	nonUnixUserInteraction