Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 5 insertions, 5 deletions

diff --git a/tests/send.test b/tests/send.test
index e3156a1..3083314 100644
--- a/tests/send.test
+++ b/tests/send.test
@@ -19,7 +19,7 @@ testConstraint xhost [llength [auto_execok xhost]]
 # Compute a script that will load Tk into a child interpreter.
 
 foreach pkg [info loaded] {
-    if {[lindex $pkg 1] == "Tk"} {
+    if {[lindex $pkg 1] eq "Tk"} {
 	set loadTk "load $pkg"
 	break
     }
@@ -29,7 +29,7 @@ foreach pkg [info loaded] {
 
 proc newApp {screen name class} {
     global loadTk
-    interp create $name
+    interp create -- $name
     $name eval [list set argv [list -display $screen -name $name -class $class]]
     eval $loadTk $name
 }
@@ -312,7 +312,7 @@ test send-8.17 {Tk_SendCmd procedure, deferring events} {secureserver nonPortabl
     setupbg
     set app [dobg {tk appname}]
     raise .		; # Don't want new app obscuring .f
-    catch {destroy .f}
+    destroy .f
     frame .f
     place .f -x 0 -y 0
     bind .f <Expose> {set a exposed}
@@ -350,7 +350,7 @@ test send-8.19 {Tk_SendCmd, using modal timeouts} {secureserver} {
 } {{x y z} no yes}
 
 tk appname tktest
-catch {destroy .f}
+destroy .f
 frame .f
 set id [string range [winfo id .f] 2 end]
 
@@ -531,7 +531,7 @@ test send-11.2 {AppendPropCarefully and AppendErrorProc procedures} {secureserve
 
 winfo interps
 tk appname tktest
-catch {destroy .f}
+destroy .f
 frame .f
 set id [string range [winfo id .f] 2 end]