Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 5 insertions, 6 deletions

diff --git a/tests/ttk/panedwindow.test b/tests/ttk/panedwindow.test
index 7fe5c87..3fbeea1 100644
--- a/tests/ttk/panedwindow.test
+++ b/tests/ttk/panedwindow.test
@@ -1,5 +1,6 @@
 package require Tk 8.5
-package require tcltest ; namespace import -force tcltest::*
+package require tcltest
+namespace import -force tcltest::*
 loadTestedCommands
 
 proc propagate-geometry {} { update idletasks }
@@ -88,7 +89,7 @@ test panedwindow-2.2 "..., cont'd" -body {
     set w3 [winfo width .]
     set rw3 [winfo reqwidth .pw]
 
-    expr {$w3 == $w2 && $rw3 < $rw2}
+    expr {($w3 == $w2) && ($rw3 < $rw2)}
     # problem: [winfo reqwidth] shrinks, but sashes haven't moved
     # since we haven't gotten a ConfigureNotify.
     # How to (a) check for this, and (b) fix it?
@@ -124,10 +125,8 @@ test panedwindow-3.2 "add pane -- errors" -body {
     .pw add [ttk::label .pw.l] -weight -1
 } -returnCodes 1 -match glob -result "-weight must be nonnegative"
 
-
 test panedwindow-3.end "cleanup" -body { destroy .pw }
 
-
 test panedwindow-4.1 "forget" -body {
     pack [ttk::panedwindow .pw -orient vertical] -expand true -fill both
     .pw add [label .pw.l1 -text "L1"]
@@ -201,7 +200,7 @@ test panedwindow-5.1 "Propagate Map/Unmap state to children" -body {
 proc sashpositions {pw} {
     set positions [list]
     set npanes [llength [winfo children $pw]]
-    for {set i 0} {$i < $npanes - 1} {incr i} {
+    for {set i 0} {$i < ($npanes - 1)} {incr i} {
     	lappend positions [$pw sashpos $i]
     }
     return $positions
@@ -219,7 +218,7 @@ test paned-sashpos-setup "Setup for sash position test" -body {
 
     propagate-geometry
     list [winfo reqwidth .pw] [winfo reqheight .pw]
-} -result [list 20 [expr {20*4 + 5*3}]]
+} -result [list 20 [expr {(20 * 4) + (5 * 3)}]]
 
 test paned-sashpos-attempt-restore "Attempt to set sash positions" -body {
     # This is not expected to succeed, since .pw isn't large enough yet.