Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 2 insertions, 3 deletions

diff --git a/tests/ttk/validate.test b/tests/ttk/validate.test
index 417deac..4d9d5ca 100644
--- a/tests/ttk/validate.test
+++ b/tests/ttk/validate.test
@@ -22,8 +22,7 @@ test validate-0.0 "Setup" -constraints ttkEntry -body {
 
 test validate-0.1 "More setup" -body {
     destroy .e
-    catch {unset ::e}
-    catch {unset ::vVals}
+    unset -nocomplain ::e ::vVals
     entry .e -validate all \
 	    -validatecommand [list doval %W %d %i %P %s %S %v %V] \
 	    -invalidcommand bell \
@@ -209,7 +208,7 @@ test validate-2.1 "Validation script changes value" -body {
 # DIFFERENCE: core entry disables validation, ttk entry does not.
 
 destroy .e
-catch {unset ::e ::vVals}
+unset -nocomplain ::e ::vVals
 
 # See bug #1236979