Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 8 insertions, 8 deletions

diff --git a/tests/unixSelect.test b/tests/unixSelect.test
index 53ae006..bba74cf 100644
--- a/tests/unixSelect.test
+++ b/tests/unixSelect.test
@@ -26,7 +26,7 @@ proc handler {type offset count} {
     if {$numBytes <= 0} {
     return ""
     }
-    string range $selValue $offset [expr $numBytes+$offset]
+    string range $selValue $offset [expr {$numBytes + $offset}]
 }
 
 proc errIncrHandler {type offset count} {
@@ -45,10 +45,10 @@ proc errIncrHandler {type offset count} {
     if {$numBytes <= 0} {
     return ""
     }
-    string range $selValue $offset [expr $numBytes+$offset]
+    string range $selValue $offset [expr {$numBytes + $offset}]
 }
 
-proc errHandler args {
+proc errHandler {args} {
     error "selection handler aborted"
 }
 
@@ -60,7 +60,7 @@ proc badHandler {path type offset count} {
     if {$numBytes <= 0} {
     return ""
     }
-    string range $selValue $offset [expr $numBytes+$offset]
+    string range $selValue $offset [expr {$numBytes + $offset}]
 }
 proc reallyBadHandler {path type offset count} {
     global selValue selInfo pass
@@ -76,20 +76,20 @@ proc reallyBadHandler {path type offset count} {
     if {$numBytes <= 0} {
     return ""
     }
-    string range $selValue $offset [expr $numBytes+$offset]
+    string range $selValue $offset [expr {$numBytes + $offset}]
 }
 
 # Eliminate any existing selection on the screen.  This is needed in case
 # there is a selection in some other application, in order to prevent races
 # from causing false errors in the tests below.
 
-selection clear .
+selection clear -displayof .
 after 1500
 
 # common setup code
 proc setup {{path .f1} {display {}}} {
-    catch {destroy $path}
-    if {$display == {}} {
+    destroy $path
+    if {$display eq ""} {
     frame $path
     } else {
     toplevel $path -screen $display