Contribution by Patrick Fradin <patrick.fradin@planar.com>contrib_patrick_fradin_code_cleanup

Quoting his mail:

<pre>
==========================================================
Hi Jeff,

I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)

I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)

I've made some improvements too :

Examples :

- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.

- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
  factorise some eq/ne && / || tests.

- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.

- Use 'unset -nocomplain' to avoid 'catch {unset...}'.

- Remove some useless catch around 'destroy' calls.

- Use expand {*} instead of 'eval'. Don't touch a lot of code because
  I don't know all structs and lists. I think it could be a greater
  improvement to reduce 'eval' calls.

Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>

1 files changed, 1 insertions, 7 deletions

diff --git a/tests/winWm.test b/tests/winWm.test
index ad4988d..491310b 100644
--- a/tests/winWm.test
+++ b/tests/winWm.test
@@ -14,7 +14,6 @@ namespace import ::tcltest::*
 tcltest::configure {*}$argv
 tcltest::loadTestedCommands
 
-
 test winWm-1.1 {TkWmMapWindow} -constraints win -setup {
     destroy .t
 } -body {
@@ -73,7 +72,6 @@ test winWm-1.5 {TkWmMapWindow} -constraints win -setup {
     wm state .t
 } -result {iconic}
 
-
 test winWm-2.1 {TkpWmSetState} -constraints win -setup {
     destroy .t
 } -body {
@@ -149,7 +147,6 @@ test winWm-2.4 {TkpWmSetState} -constraints win -setup {
     destroy .t
 } -result {{normal 150x50+10+10} {iconic 150x50+10+10} {iconic 150x50+10+10} {normal 200x50+10+10}}
 
-
 test winWm-3.1 {ConfigureTopLevel: window geometry propagation} -constraints {
     win
 } -setup {
@@ -173,7 +170,6 @@ test winWm-3.1 {ConfigureTopLevel: window geometry propagation} -constraints {
     destroy .t
 } -result 1
 
-
 test winWm-4.1 {ConfigureTopLevel: menu resizing} -constraints win -setup {
     destroy .t
 } -body {
@@ -363,7 +359,6 @@ test winWm-6.8 {wm attributes -transparentcolor} -constraints win -setup {
     destroy .t
 } -returnCodes error -result {unknown color name "foo"}
 
-
 test winWm-7.1 {deiconify on an unmapped toplevel will raise \
         the window and set the focus} -constraints {
     win
@@ -426,7 +421,6 @@ test winWm-7.4 {UpdateWrapper must maintain focus} -constraints win -setup {
     destroy .t
 } -result {.t .t}
 
-
 test winWm-8.1 {Tk_WmCmd procedure, "iconphoto" option} -constraints win -body {
     wm iconph .
 } -returnCodes error -result {wrong # args: should be "wm iconphoto window ?-default? image1 ?image2 ...?"}
@@ -551,7 +545,7 @@ test winWm-9.2 "check wm forget for unmapped parent (#3205464,#2967911)" -setup
                 pack .t.f
                 lappend aid [after 100 {
 		    set ::winwm92 [expr {
-			    [winfo rooty .t.f.x] == 0 ? "failed" : "ok"}]}]
+			    ([winfo rooty .t.f.x] == 0) ? "failed" : "ok"}]}]
             }]
         }]
     }]