The possible cause for unixEmbed-10.2 and frame-3.10 tests failures on macOS mentioned in the comments of proc deleteWindows is not the correct one. Keep the workaround (the return statement) and change the destroy line anyway.

1 files changed, 1 insertions, 4 deletions

diff --git a/tests/constraints.tcl b/tests/constraints.tcl
index c3d21bb..ad0ca85 100644
--- a/tests/constraints.tcl
+++ b/tests/constraints.tcl
@@ -121,15 +121,12 @@ namespace eval tk {
 
 	namespace export deleteWindows
 	proc deleteWindows {} {
-	    eval destroy [winfo children .]
+	    destroy {*}[winfo children .]
 	    # This update is needed to avoid intermittent failures on macOS in unixEmbed.test
 	    # with the (GitHub Actions) CI runner.
 	    # Reason for the failures is unclear but could have to do with window ids being deleted
 	    # after the destroy command returns. The detailed mechanism of such delayed deletions
 	    # is not understood, but it appears that this update prevents the test failures.
-	    # Question: Is this perhaps due to the above call to 'eval' leading to callbacks
-	    #           creation and in turn to delayed deletions? To be checked, and probably
-	    #           anyway replace this line by  'destroy {*}[winfo children .]'
 	    update
 	}